Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scancode-toolkit to latest version #537

Merged
merged 19 commits into from
Jun 26, 2024

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented Jan 18, 2024

This is the initial version of the changes needed to update scancode-toolkit to the latest version. Further changes will be necessary in clearlydefined/service to be able to handle the output from recent versions of ScanCode where the data format has changed fairly dramatically in parts.

Dockerfile Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
@lumaxis lumaxis force-pushed the update-scancode-toolkit branch from 62f1e25 to 236234b Compare April 5, 2024 11:38
@lumaxis lumaxis marked this pull request as ready for review April 30, 2024 09:58
@lumaxis lumaxis requested review from qtomlinson and elrayle April 30, 2024 09:58
DevDockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Copy link
Collaborator

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed explanation!

Copy link
Collaborator

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I see a couple of outstanding questions from @qtomlinson. Once those are resolved, let's get this merged.

Thanks for all the great work that went into getting scancode upgraded and adding LicenseRefs support.

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@qtomlinson qtomlinson merged commit 8f692e6 into clearlydefined:master Jun 26, 2024
2 checks passed
@lumaxis lumaxis deleted the update-scancode-toolkit branch June 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants