Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added ordinalDirection generation function #992

Merged
merged 3 commits into from
Nov 23, 2024
Merged

feat: added ordinalDirection generation function #992

merged 3 commits into from
Nov 23, 2024

Conversation

BAKAJ77
Copy link
Contributor

@BAKAJ77 BAKAJ77 commented Nov 23, 2024

  • Implemented random ordinal direction generation function.
  • Added testing code for the ordinal direction generation function.

@BAKAJ77
Added ordinalDirection function
fad5e1e 
- Implemented random ordinal direction generation function.
- Added testing code for the ordinal direction generation function.
@BAKAJ77
Copy link
Contributor Author

BAKAJ77 commented Nov 23, 2024

The changes made in this pull request are aimed to solve this issue.

@cieslarmichal cieslarmichal linked an issue Nov 23, 2024 that may be closed by this pull request
add ordinalDirection function to Location module #939
Closed
cieslarmichal
cieslarmichal requested changes Nov 23, 2024
View reviewed changes
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix formatting

@cieslarmichal
Copy link
Owner

run clang format

@BAKAJ77
Copy link
Contributor Author

BAKAJ77 commented Nov 23, 2024

I keep getting this error when I run the script:

YAML:43:15: error: invalid boolean
SortIncludes: CaseInsensitive
              ^~~~~~~~~~~~~~~
Error reading <Path>/.clang-format: invalid argument

@cieslarmichal
Copy link
Owner

What clang format version do you have?

@BAKAJ77
Copy link
Contributor Author

BAKAJ77 commented Nov 23, 2024

Nevermind, I re-downloaded the clang-format executable and now it works

@BAKAJ77
Copy link
Contributor Author

BAKAJ77 commented Nov 23, 2024

@cieslarmichal I think that should do it for the formatting, double checked just to make sure.

@cieslarmichal cieslarmichal merged commit 576187d into cieslarmichal:main Nov 23, 2024
13 checks passed
@BAKAJ77 BAKAJ77 deleted the feature/ordinaldirectiongen branch November 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cieslarmichal cieslarmichal cieslarmichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add ordinalDirection function to Location module
2 participants
@BAKAJ77 @cieslarmichal