Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ordinalDirection function to Location module #939

Closed
cieslarmichal opened this issue Oct 3, 2024 · 7 comments · Fixed by #992
Closed

add ordinalDirection function to Location module #939

cieslarmichal opened this issue Oct 3, 2024 · 7 comments · Fixed by #992
Assignees
@BAKAJ77
Labels
good first issue Good for newcomers
Milestone
v4.0.0

Comments

@cieslarmichal
Copy link
Owner

like https://fakerjs.dev/api/location.html#ordinaldirection
@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Oct 3, 2024
@cieslarmichal cieslarmichal added this to the v4.0.0 milestone Oct 3, 2024
@Nystana
Copy link

Nystana commented Oct 7, 2024

Hello, I'd like to try this issue

@cieslarmichal
Copy link
Owner Author

Ok, go ahead :) assigned

@cieslarmichal
Copy link
Owner Author

Consider giving a star to the repository to make this project more popular 😎

@cieslarmichal
Copy link
Owner Author

any progress?

@BAKAJ77
Copy link
Contributor

BAKAJ77 commented Nov 23, 2024 •
edited
Loading

Hello, I can do this issue if it's still valid @cieslarmichal

@cieslarmichal
Copy link
Owner Author

hello, yes its still TODO, assigned

@cieslarmichal
Copy link
Owner Author

Consider also giving a star to the repository & joining discord channel!

@BAKAJ77 BAKAJ77 mentioned this issue Nov 23, 2024
Merged
@cieslarmichal cieslarmichal linked a pull request Nov 23, 2024 that will close this issue
feat: added ordinalDirection generation function #992
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BAKAJ77 BAKAJ77

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

feat: added ordinalDirection generation function BAKAJ77/faker-cxx
3 participants
@BAKAJ77 @cieslarmichal @Nystana