Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Video Game #586

Merged
merged 13 commits into from
May 25, 2024
Merged

Conversation

uilianries
Copy link
Contributor

closes #580

Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries marked this pull request as draft May 25, 2024 09:47
@uilianries
Copy link
Contributor Author

Converting to draft until fixing it.

@uilianries uilianries marked this pull request as ready for review May 25, 2024 21:13
@uilianries
Copy link
Contributor Author

@cieslarmichal Now it's good for review.

@cieslarmichal cieslarmichal merged commit 7b92d63 into cieslarmichal:main May 25, 2024
6 checks passed
00thirdeye00 pushed a commit to 00thirdeye00/faker-cxx that referenced this pull request Jun 20, 2024
* Add VideoGameData draft

Signed-off-by: Uilian Ries <[email protected]>

* Add rest of data to VideoGame

Signed-off-by: Uilian Ries <[email protected]>

* Fix helper usage for video game

Signed-off-by: Uilian Ries <[email protected]>

* avoid circular include

Signed-off-by: Uilian Ries <[email protected]>

* build missing videogame data

Signed-off-by: Uilian Ries <[email protected]>

* Add namespace for videogame

Signed-off-by: Uilian Ries <[email protected]>

* Use video game namespace for testing

Signed-off-by: Uilian Ries <[email protected]>

* fix genres conflict

Signed-off-by: Uilian Ries <[email protected]>

* Use explicit namespace

Signed-off-by: Uilian Ries <[email protected]>

* use separated name for video game genres

Signed-off-by: Uilian Ries <[email protected]>

* Revert "fix genres conflict"

This reverts commit bac4da6.

---------

Signed-off-by: Uilian Ries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor video game module data
2 participants