Refactor Video Game (#586)

* Add VideoGameData draft Signed-off-by: Uilian Ries <[email protected]> * Add rest of data to VideoGame Signed-off-by: Uilian Ries <[email protected]> * Fix helper usage for video game Signed-off-by: Uilian Ries <[email protected]> * avoid circular include Signed-off-by: Uilian Ries <[email protected]> * build missing videogame data Signed-off-by: Uilian Ries <[email protected]> * Add namespace for videogame Signed-off-by: Uilian Ries <[email protected]> * Use video game namespace for testing Signed-off-by: Uilian Ries <[email protected]> * fix genres conflict Signed-off-by: Uilian Ries <[email protected]> * Use explicit namespace Signed-off-by: Uilian Ries <[email protected]> * use separated name for video game genres Signed-off-by: Uilian Ries <[email protected]> * Revert "fix genres conflict" This reverts commit bac4da6. --------- Signed-off-by: Uilian Ries <[email protected]>
cieslarmichal · May 25, 2024 · 7b92d63 · 7b92d63
1 parent 3bb1d7a
commit 7b92d63
Show file tree

Hide file tree

Showing 9 changed files with 3,000 additions and 3,000 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -53,6 +53,7 @@ set(FAKER_SOURCES
     src/modules/system/System.cpp
     src/modules/vehicle/Vehicle.cpp
     src/modules/videoGame/VideoGame.cpp
+    src/modules/videoGame/VideoGameData.cpp
     src/modules/weather/Weather.cpp
     src/modules/word/Word.cpp
     src/common/FormatHelper.cpp

diff --git a/include/faker-cxx/VideoGame.h b/include/faker-cxx/VideoGame.h
@@ -1,6 +1,6 @@
 #pragma once
 
-#include <string>
+#include <string_view>
 
 namespace faker
 {
@@ -16,7 +16,7 @@ class VideoGame
      * VideoGame::gameTitle() // "Rayman Arena"
      * @endcode
      */
-    static std::string gameTitle();
+    static std::string_view gameTitle();
 
     /**
      * @brief Returns a random video game genre.
@@ -27,7 +27,7 @@ class VideoGame
      * VideoGame::genre() // "Platformer"
      * @endcode
      */
-    static std::string genre();
+    static std::string_view genre();
 
     /**
      * @brief Returns a random video game platform.
@@ -38,7 +38,7 @@ class VideoGame
      * VideoGame::platform() // "Playstation 5"
      * @endcode
      */
-    static std::string platform();
+    static std::string_view platform();
 
     /**
      * @brief Returns a random video game studio name.
@@ -49,6 +49,6 @@ class VideoGame
      * VideoGame::studioName() // "Activision Blizzard"
      * @endcode
      */
-    static std::string studioName();
+    static std::string_view studioName();
 };
 }
diff --git a/src/modules/videoGame/VideoGame.cpp b/src/modules/videoGame/VideoGame.cpp
@@ -1,30 +1,28 @@
 #include "faker-cxx/VideoGame.h"
 
-#include "data/GameTitles.h"
-#include "data/Genres.h"
-#include "data/Platforms.h"
-#include "data/StudioNames.h"
+#include "VideoGameData.h"
 #include "faker-cxx/Helper.h"
 
+
 namespace faker
 {
-std::string VideoGame::gameTitle()
+std::string_view VideoGame::gameTitle()
 {
-    return Helper::arrayElement<std::string>(videoGameNames);
+    return Helper::arrayElement(videoGame::videoGameNames);
 }
 
-std::string VideoGame::genre()
+std::string_view VideoGame::genre()
 {
-    return Helper::arrayElement<std::string>(videoGameGenres);
+    return Helper::arrayElement(videoGame::videoGameGenres);
 }
 
-std::string VideoGame::platform()
+std::string_view VideoGame::platform()
 {
-    return Helper::arrayElement<std::string>(platforms);
+    return Helper::arrayElement(videoGame::platforms);
 }
 
-std::string VideoGame::studioName()
+std::string_view VideoGame::studioName()
 {
-    return Helper::arrayElement<std::string>(studioNames);
+    return Helper::arrayElement(videoGame::studioNames);
 }
 }