test: phone module testcase added

* test case added to phone module for code coverage Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal · Jul 24, 2024 · d102574 · d102574
1 parent b427d69
commit d102574
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/include/faker-cxx/phone.h b/include/faker-cxx/phone.h
@@ -325,6 +325,7 @@ enum class PhoneNumberCountryFormat
     WesternSahara,
     Yemen,
     Zambia,
-    Zimbabwe
+    Zimbabwe,
+    Empty
 };
 }
diff --git a/src/modules/phone.cpp b/src/modules/phone.cpp
@@ -31,11 +31,11 @@ std::string phoneNumberByFormat(std::optional<std::string> format)
 
 std::string phoneNumberByCountry(PhoneNumberCountryFormat format)
 {
-    std::string countryFormat = phoneNumberFormatMap.at(format);
+    std::string countryFormat = (format == PhoneNumberCountryFormat::Empty)? "" : phoneNumberFormatMap.at(format);
 
     if (countryFormat.empty())
     {
-        return phoneNumberFormatMap.at(PhoneNumberCountryFormat::Default);
+        countryFormat = phoneNumberFormatMap.at(PhoneNumberCountryFormat::Default);
     }
 
     return helper::replaceSymbolWithNumber(countryFormat);

diff --git a/src/modules/phone_data.h b/src/modules/phone_data.h
@@ -271,7 +271,7 @@ const auto phoneNumbers = std::to_array<std::string_view>({
     "+212 (###) ####",      // Western Sahara
     "+967 (###) ###-####",  // Yemen
     "+260 (###) ###-####",  // Zambia
-    "+263 (###) ####"       // Zimbabwe
+    "+263 (###) ####",      // Zimbabwe
 });
 
 }
diff --git a/tests/modules/phone_test.cpp b/tests/modules/phone_test.cpp
@@ -61,6 +61,16 @@ TEST_F(PhoneTest, NumberWithCountryFormat)
     ASSERT_TRUE(isStringNumericWithSpecialChars(generatedPhoneNumber));
 }
 
+TEST_F(PhoneTest, NumberWithEmptyCountryFormat)
+{
+    const auto generatedPhoneNumber = phoneNumberByCountry(PhoneNumberCountryFormat::Empty);
+
+    std::cout << generatedPhoneNumber << std::endl;
+
+    EXPECT_FALSE(generatedPhoneNumber.empty());
+    ASSERT_TRUE(isStringNumericWithSpecialChars(generatedPhoneNumber));
+}
+
 TEST_F(PhoneTest, IMEIGeneration)
 {
     auto generatedImei = imei();