test: finance module testcase added (#830)

* test case added to finance module for code coverage Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal · Jul 24, 2024 · b427d69 · b427d69
1 parent 55760ef
commit b427d69
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/include/faker-cxx/finance.h b/include/faker-cxx/finance.h
@@ -207,6 +207,7 @@ namespace faker::finance
 
     enum class CreditCardType
     {
+        DefaultCard,
         AmericanExpress,
         Discover,
         MasterCard,

diff --git a/src/modules/finance.cpp b/src/modules/finance.cpp
@@ -128,6 +128,8 @@ std::string creditCardNumber(std::optional<CreditCardType> creditCardType)
             static_cast<std::string>(helper::arrayElement(masterCardCreditCardFormats)));
     case CreditCardType::Visa:
         return helper::replaceCreditCardSymbols(static_cast<std::string>(helper::arrayElement(visaCreditCardFormats)));
+    default:
+        ;
     }
 
     return "";

diff --git a/tests/modules/finance_test.cpp b/tests/modules/finance_test.cpp
@@ -293,6 +293,12 @@ TEST_F(FinanceTest, shouldGenerateCreditCardNumber)
     ASSERT_TRUE(common::luhnCheck(generatedCreditCardNumber));
 }
 
+TEST_F(FinanceTest, shouldGenerateEmptyCreditCardNumber)
+{
+    const auto emptyString = "";
+    ASSERT_TRUE(emptyString == creditCardNumber(CreditCardType::DefaultCard));
+}
+
 TEST_F(FinanceTest, shouldGenerateAmericanExpressCreditCardNumber)
 {
     const auto generatedCreditCardNumber = creditCardNumber(CreditCardType::AmericanExpress);