Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space sometimes visible below header swoop #176

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix: space sometimes visible below header swoop #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd4779d
fix: space sometimes visible below header swoop
chrisvogt Jun 3, 2024
28b23e9
SQUASHME: fixup tests
chrisvogt Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion theme/src/components/__snapshots__/header.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ exports[`Header matches the snapshot 1`] = `
Wow!
</div>
<svg
className="css-1l6n94m"
className="css-odb3nj"
height="auto"
preserveAspectRatio="xMidYMin slice"
viewBox="0 0 1366 63"
width="100%"
Expand Down
3 changes: 2 additions & 1 deletion theme/src/components/swoops/__snapshots__/swoop-bottom.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

exports[`SwoopBottom matches the snapshot 1`] = `
<svg
className="css-1l6n94m"
className="css-odb3nj"
height="auto"
preserveAspectRatio="xMidYMin slice"
viewBox="0 0 1366 63"
width="100%"
Expand Down
6 changes: 5 additions & 1 deletion theme/src/components/swoops/swoop-bottom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,13 @@ export default ({ fill }) => {
preserveAspectRatio='xMidYMin slice'
xmlns='http://www.w3.org/2000/svg'
viewBox='0 0 1366 63'
height='auto'
sx={{
fill: fill || defaultFillColor,
verticalAlign: 'bottom'
verticalAlign: 'bottom',
// Hack to fix a bug in some browser where a fraction of a pixel
// of space is sometimes rendered below the swoop
marginBottom: '-1px'
}}
>
<path
Expand Down
Loading