Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space sometimes visible below header swoop #176

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

chrisvogt
Copy link
Owner

This PR fixes a bug sometimes visible below the white accent swoop in the header. It's visible in Safari on smaller screen sizes.

Screenshot 2024-06-02 at 5 36 46 PM

@chrisvogt chrisvogt self-assigned this Jun 3, 2024
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for chrisvogt ready!

Name Link
🔨 Latest commit 28b23e9
🔍 Latest deploy log https://app.netlify.com/sites/chrisvogt/deploys/665d113b241b730008fad5db
😎 Deploy Preview https://deploy-preview-176--chrisvogt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisvogt
Copy link
Owner Author

This has fixed the spacing issue that was visible on my phone.

image

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.87%. Comparing base (7ca6418) to head (28b23e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   65.87%   65.87%           
=======================================
  Files          64       64           
  Lines         586      586           
  Branches      151      151           
=======================================
  Hits          386      386           
  Misses        188      188           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisvogt chrisvogt merged commit fec4f1d into main Jun 3, 2024
8 checks passed
@chrisvogt chrisvogt deleted the fix-swoop-space branch June 3, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant