[RFC] emulation devices for t1rocket #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OceanS2000
force-pushed
the
t1rocket-emu-devices
branch
from
9b4b185 to
5316af9
Compare
FanShupei
previously requested changes
Oct 15, 2024
OceanS2000
force-pushed
the
t1rocket-emu-devices
branch
2 times, most recently
from
2283c59 to
7381b65
Compare
|
The code seems good now. The last concern is that the refactor exposes an existing limitation of our simulation framework: HOW to handle speculative load. The previous code returns garbage data when prefetch is out of bound. The new code will panic immediately. I suspect this behavior change is why we have to change testcases to make it happy. |
OceanS2000
force-pushed
the
t1rocket-emu-devices
branch
3 times, most recently
from
a41fb69 to
70e33fa
Compare
Clo91eaf
force-pushed
the
t1rocket-emu-devices
branch
3 times, most recently
from
c83b5b0 to
bb493ae
Compare
|
LGTM |
sequencer
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extensible devices emulation for t1rocket simulation dpi backend. Currently only simple Memory device is implemented, and more devices with more functionality are expected to come.