Update SRAM.scala to improve perf on non-full sized reads #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change a_sublane to not count sublanes if it's a read. Reads return full data width, no matter if the A channel size is not the data width
jerryz123
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Description:
Change a_sublane to not count sublanes if it's a read. Reads return full data width, no matter if the A channel size is not the data width
Comments
Noticed that when size is not maxed out on a read to the TLRAM, it was translating it to a RMW. Would make sense if there was an ECC error but that should get handled by d_need_fix in d_wb, sublane should not be responsible.
val d_wb = d_full && (d_sublane || d_atomic || (d_read && d_need_fix))