Introducing ref_typespec, parallel to ref_obj for referencing typespecs #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scope::Typespecs are cloned from non-elaborated tree to the elaborated tree. However, at the moment, this collection doesn't have all the typespecs in the non-elaborated tree. This solves a few different problems - * Avoids too many duplicates in the elaborated tree. * For functions like $size and $bits, the parameter binding doesn't work because the parameter is a type and not an object. ref_typespec solves that binding problem. * ref_typespec will hold the type location information in parameter declaration. Known Issues - * Need to collect all typespecs in the scope subtree to populate scope::Typespecs * Though the typespecs are cloned, elaborated tree is still using the ones from the non-elaborated tree. The tree is still complete but typespecs are crossing the boundary between elaborated and non-elaborated. Need to fix this during binding.
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 20, 2023
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 20, 2023
|
Here's the PR for the plugin - chipsalliance/synlig#2000 And here's a successful build with this PR and the plugin PR - https://github.com/chipsalliance/Surelog/actions/runs/6252535173 |
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 21, 2023
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 21, 2023
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 21, 2023
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 22, 2023
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 22, 2023
hs-apotell
added a commit
to Apotell/synlig
that referenced
this pull request
Sep 22, 2023
kgugala
added a commit
to chipsalliance/synlig
that referenced
this pull request
Sep 22, 2023
Handle introduction of ref_typespec in UHDM/Surelog chipsalliance/UHDM#1022 chipsalliance/Surelog#3868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing ref_typespec, parallel to ref_obj for referencing typespecs
scope::Typespecs are cloned from non-elaborated tree to the elaborated tree. However, at the moment, this collection doesn't have all the typespecs in the non-elaborated tree.
This solves a few different problems -
Known Issues -