Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider test requirements (U mode) in matrix #287

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

wsipak
Copy link
Collaborator

@wsipak wsipak commented Dec 6, 2024

There are tests which require user mode. They fail in CI when run without user mode.

if ((_read_csr(misa) & MISA_U) == 0) {
printf("ERROR: The test requires user mode support. Aborting.\n");
return -1;
}

if ((read_csr(misa) & MISA_U) == 0) {
printf("ERROR: The test requires user mode support. Aborting.\n");
return -1;
}

if ((read_csr(misa) & MISA_U) == 0) {
printf("ERROR: The test requires user mode support. Aborting.\n");
return -1;
}

// The test requires user mode support
if ((read_csr(misa) & MISA_U) == 0) {
printf("ERROR: The test requires user mode support. Aborting.\n");
return -1;
}

// The test requires user mode support
if ((read_csr(CSR_MISA) & MISA_U) == 0) {
printf("ERROR: The test requires user mode support. Aborting.\n");
return -1;
}

Copy link

github-actions bot commented Dec 6, 2024

Links to coverage and verification reports for this PR (#287) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak marked this pull request as ready for review December 9, 2024 10:19
Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichalak tmichalak merged commit 6d828bc into main Dec 9, 2024
383 checks passed
@wsipak wsipak deleted the wsip/test_requirements branch December 11, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants