Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix icache #286

Merged
merged 5 commits into from
Dec 6, 2024
Merged

fix icache #286

merged 5 commits into from
Dec 6, 2024

Conversation

wsipak
Copy link
Collaborator

@wsipak wsipak commented Dec 5, 2024 •
edited
Loading

  1. Fix ICache bug: only a single icache way was written in the exported sram.
  2. Add a test which covers the issue

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Links to coverage and verification reports for this PR (#286) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak marked this pull request as ready for review December 5, 2024 18:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Links to coverage and verification reports for this PR (#286) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Links to coverage and verification reports for this PR (#286) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

tmichalak
tmichalak approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichalak tmichalak merged commit d47aa79 into main Dec 6, 2024
411 checks passed
@wsipak wsipak deleted the wsip/fix_icache branch December 11, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmichalak tmichalak tmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsipak @tmichalak