Bump Verilator to v5.024 #223
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
design/lib/axi4_to_ahb.sv
Outdated
| @@ -365,15 +367,15 @@ import el2_pkg::*; | |||
| buf_data_wr_en = buf_wr_en; | |||
|
|
|||
| cmd_done = (ahb_hresp_q | (ahb_hready_q & (ahb_htrans_q[1:0] != 2'b0) & | |||
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
| cmd_done = (ahb_hresp_q | (ahb_hready_q & (ahb_htrans_q[1:0] != 2'b0) & | |
| cmd_done = (ahb_hresp_q | (ahb_hready_q & (ahb_htrans_q[1:0] != 2'b0) & |
design/lib/axi4_to_ahb.sv
Outdated
| @@ -266,6 +266,8 @@ import el2_pkg::*; | |||
|
|
|||
| // FIFO state machine | |||
| always_comb begin | |||
| // Temporary variable created to fix SIDEEFFECT warnings | |||
| logic [2:0] get_nextbyte_ptr_result = get_nxtbyte_ptr(buf_cmd_byte_ptrQ[2:0],buf_byteen[7:0],1'b1); | |||
There was a problem hiding this comment.
Line length exceeds max: 100; is: 105 [Style: line-length] [line-length]
design/lib/axi4_to_ahb.sv
Outdated
| @@ -365,15 +367,15 @@ | |||
| buf_data_wr_en = buf_wr_en; | |||
|
|
|||
| cmd_done = (ahb_hresp_q | (ahb_hready_q & (ahb_htrans_q[1:0] != 2'b0) & | |||
| ((buf_cmd_byte_ptrQ == 3'b111) | (buf_byteen[get_nxtbyte_ptr(buf_cmd_byte_ptrQ[2:0],buf_byteen[7:0],1'b1)] == 1'b0)))); | |||
| ((buf_cmd_byte_ptrQ == 3'b111) | (buf_byteen[get_nextbyte_ptr_result] == 1'b0)))); | |||
There was a problem hiding this comment.
Line length exceeds max: 100; is: 115 [Style: line-length] [line-length]
design/lib/axi4_to_ahb.sv
Outdated
| bypass_en = buf_state_en & buf_write_in & (buf_nxtstate == CMD_WR); // Only bypass for writes for the time being | ||
| ahb_htrans[1:0] = {2{(~(cmd_done | cmd_doneQ) | bypass_en)}} & 2'b10; | ||
| slave_valid_pre = buf_state_en & (buf_nxtstate != DONE_WR); | ||
|
|
||
| trxn_done = ahb_hready_q & ahb_hwrite_q & (ahb_htrans_q[1:0] != 2'b0); | ||
| buf_cmd_byte_ptr_en = trxn_done | bypass_en; | ||
| buf_cmd_byte_ptr = bypass_en ? get_nxtbyte_ptr(3'b0,buf_byteen_in[7:0],1'b0) : | ||
| trxn_done ? get_nxtbyte_ptr(buf_cmd_byte_ptrQ[2:0],buf_byteen[7:0],1'b1) : buf_cmd_byte_ptrQ; | ||
| trxn_done ? get_nextbyte_ptr_result : buf_cmd_byte_ptrQ; |
There was a problem hiding this comment.
Line length exceeds max: 100; is: 105 [Style: line-length] [line-length]
RRozak
force-pushed
the
rrozak/62517-bump-verilator
branch
from
ff8fc00 to
f2d82b6
Compare
RRozak
changed the title
|
Links to coverage and verification reports for this PR (#223) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
Internal-tag: [#62517] Signed-off-by: Ryszard Rozak <[email protected]>
Internal-tag: [#62517] Signed-off-by: Ryszard Rozak <[email protected]>
RRozak
force-pushed
the
rrozak/62517-bump-verilator
branch
from
f2d82b6 to
eb1dc09
Compare
Internal-tag: [#62517] Signed-off-by: Ryszard Rozak <[email protected]>
|
Links to coverage and verification reports for this PR (#223) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
|
Links to coverage and verification reports for this PR (#223) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
It bumps Verilator to the version 5.024.
It can't be bumped to the newest, because it is currently unsupported by cocotb: cocotb/cocotb#3896.
I removed the assignment in the declaration of
resultvariable to prevent from seg fault. That assignment is redundant, because the value is assigned in each branch ofifandcase.The problem that cause seg fault is fixed in the newest Verilator: verilator/verilator#5365.