Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a test for user mode #185

Merged
merged 6 commits into from
Aug 8, 2024
Merged

add a test for user mode #185

merged 6 commits into from
Aug 8, 2024

Conversation

wsipak
Copy link
Collaborator

@wsipak wsipak commented Jun 11, 2024 •
edited
Loading

  1. Bring back USER_MODE in core settings.
  2. Add new tests for user mode using riscv-dv
  3. Add pre-generated code for the tests
  4. Specify privilege modes to be used in simulators in riscv-dv

Currently, riscv-dv doesn't allow specifying privilege modes to be enabled in simulators. There's inconsistence because whisper uses only Machine mode by default, while spike also enables Supervisor and User modes.
With this change, we're explicitly enabling U mode.

github-actions[bot]
github-actions bot reviewed Jun 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

verible-verilog-format

design/el2_pmp.sv|156|
design/el2_pmp.sv|159|
design/el2_pmp.sv|305|
design/el2_veer.sv|885|
design/el2_veer.sv|889|
design/el2_veer.sv|893|
design/include/el2_def.sv|440|
design/include/el2_def.sv|442|

design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jun 12, 2024
View reviewed changes
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jun 18, 2024
View reviewed changes
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
design/include/el2_def.sv Outdated Show resolved Hide resolved
design/include/el2_def.sv Outdated Show resolved Hide resolved
@wsipak wsipak force-pushed the wsip/u_mode branch 4 times, most recently from 32dbff4 to 64bf37b Compare June 24, 2024 13:08
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

github-actions[bot]
github-actions bot reviewed Jun 26, 2024
View reviewed changes
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

1 similar comment
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@chipsalliance chipsalliance deleted a comment from github-actions bot Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak marked this pull request as ready for review July 5, 2024 19:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak
Copy link
Collaborator Author

wsipak commented Jul 9, 2024

Tests failed on the main branch so I'm going to see what happened there first, and then check the CI results here.

@wsipak wsipak force-pushed the wsip/u_mode branch 2 times, most recently from 336fe77 to 9e48959 Compare July 10, 2024 11:37
@github-actions GitHub Actions
Copy link

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@tmichalak tmichalak mentioned this pull request Jul 24, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@kiryk kiryk mentioned this pull request Aug 8, 2024
Merged
tmichalak
tmichalak approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichalak tmichalak merged commit 70563e5 into chipsalliance:main Aug 8, 2024
237 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tmichalak tmichalak tmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsipak @tmichalak @kiryk