Fix black and isort not failing CI on incorrect formatting #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal-tag: [#59925] Signed-off-by: Krzysztof Obłonczek <[email protected]>
Internal-tag: [#59925] Signed-off-by: Krzysztof Obłonczek <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR unifies linting sessions in noxfile and adds another session that will fail the CI when
blackorisortdetects incorrect formatting. Previously these would also detect it but return with exit code 0, so it would make the CI pass even though there were linting issues.Several files had to be formatted after this change to make the CI pass again. This change is in a separate commit.