Skip to content

Commit

Permalink
remove unused interface veer_icache
Browse files Browse the repository at this point in the history
  • Loading branch information
@wsipak
wsipak committed Nov 20, 2024
1 parent e25b0a1 commit edfbff6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
2 changes: 1 addition & 1 deletion design/el2_mem.sv
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ import el2_pkg::*;
if ( pt.ICACHE_ENABLE ) begin: icache
el2_ifu_ic_mem #(.pt(pt)) icm (
.clk_override(icm_clk_override),
.icache_export(mem_export_local.veer_icache),
.icache_export(mem_export_local.veer_icache_src),
.*
);

Check warning on line 157 in design/el2_mem.sv

View workflow job for this annotation

GitHub Actions / format-review 

[verible-verilog-format] reported by reviewdog 🐶


Raw Output:
design/el2_mem.sv:157:-   );
design/el2_mem.sv:158:-end
design/el2_mem.sv:159:-else  begin
design/el2_mem.sv:160:-   assign   ic_rd_hit[pt.ICACHE_NUM_WAYS-1:0] = '0;
design/el2_mem.sv:161:-   assign   ic_tag_perr    = '0 ;
design/el2_mem.sv:162:-   assign   ic_rd_data  = '0 ;
design/el2_mem.sv:163:-   assign   ictag_debug_rd_data  = '0 ;
design/el2_mem.sv:164:-   assign   ic_debug_rd_data  = '0 ;
design/el2_mem.sv:165:-   assign   ic_eccerr      = '0;
design/el2_mem.sv:166:-end // else: !if( pt.ICACHE_ENABLE )
design/el2_mem.sv:167:-
design/el2_mem.sv:168:-
design/el2_mem.sv:169:-
design/el2_mem.sv:170:-if (pt.ICCM_ENABLE) begin : iccm
design/el2_mem.sv:171:-   el2_ifu_iccm_mem  #(.pt(pt)) iccm (.*,
design/el2_mem.sv:172:-                  .clk_override(icm_clk_override),
design/el2_mem.sv:173:-                  .iccm_rw_addr(iccm_rw_addr[pt.ICCM_BITS-1:1]),
design/el2_mem.sv:174:-                  .iccm_rd_data(iccm_rd_data[63:0]),
design/el2_mem.sv:175:-                  .iccm_mem_export(mem_export_local.veer_iccm)
design/el2_mem.sv:176:-                   );
design/el2_mem.sv:177:-end
design/el2_mem.sv:178:-else  begin
design/el2_mem.sv:179:-   assign  iccm_rd_data    = '0 ;
design/el2_mem.sv:180:-   assign iccm_rd_data_ecc = '0 ;
design/el2_mem.sv:181:-end
design/el2_mem.sv:100:+  );
design/el2_mem.sv:101:+
design/el2_mem.sv:102:+  el2_mem_if mem_export_local ();
design/el2_mem.sv:103:+
design/el2_mem.sv:104:+  assign mem_export.clk                              = clk;
design/el2_mem.sv:105:+  assign icache_export.clk                           = clk;
design/el2_mem.sv:106:+  assign mem_export_local.clk                        = clk;
design/el2_mem.sv:107:+
design/el2_mem.sv:108:+  assign mem_export.iccm_clken                       = mem_export_local.iccm_clken;
design/el2_mem.sv:109:+  assign mem_export.iccm_wren_bank                   = mem_export_local.iccm_wren_bank;
design/el2_mem.sv:110:+  assign mem_export.iccm_addr_bank                   = mem_export_local.iccm_addr_bank;
design/el2_mem.sv:111:+  assign mem_export.iccm_bank_wr_data                = mem_export_local.iccm_bank_wr_data;
design/el2_mem.sv:112:+  assign mem_export.iccm_bank_wr_ecc                 = mem_export_local.iccm_bank_wr_ecc;
design/el2_mem.sv:113:+  assign mem_export_local.iccm_bank_dout             = mem_export.iccm_bank_dout;
design/el2_mem.sv:114:+  assign mem_export_local.iccm_bank_ecc              = mem_export.iccm_bank_ecc;
design/el2_mem.sv:115:+
design/el2_mem.sv:116:+  assign mem_export.dccm_clken                       = mem_export_local.dccm_clken;
design/el2_mem.sv:117:+  assign mem_export.dccm_wren_bank                   = mem_export_local.dccm_wren_bank;
design/el2_mem.sv:118:+  assign mem_export.dccm_addr_bank                   = mem_export_local.dccm_addr_bank;
design/el2_mem.sv:119:+  assign mem_export.dccm_wr_data_bank                = mem_export_local.dccm_wr_data_bank;
design/el2_mem.sv:120:+  assign mem_export.dccm_wr_ecc_bank                 = mem_export_local.dccm_wr_ecc_bank;
design/el2_mem.sv:121:+  assign mem_export_local.dccm_bank_dout             = mem_export.dccm_bank_dout;
design/el2_mem.sv:122:+  assign mem_export_local.dccm_bank_ecc              = mem_export.dccm_bank_ecc;
design/el2_mem.sv:123:+
design/el2_mem.sv:124:+  // icache data
design/el2_mem.sv:125:+  assign icache_export.ic_b_sb_wren                  = mem_export_local.ic_b_sb_wren;
design/el2_mem.sv:126:+  assign icache_export.ic_b_sb_bit_en_vec            = mem_export_local.ic_b_sb_bit_en_vec;
design/el2_mem.sv:127:+  assign icache_export.ic_sb_wr_data                 = mem_export_local.ic_sb_wr_data;
design/el2_mem.sv:128:+  assign icache_export.ic_rw_addr_bank_q             = mem_export_local.ic_rw_addr_bank_q;
design/el2_mem.sv:129:+  assign icache_export.ic_bank_way_clken_final       = mem_export_local.ic_bank_way_clken_final;
design/el2_mem.sv:130:+  assign icache_export.ic_bank_way_clken_final_up    = mem_export_local.ic_bank_way_clken_final_up;
design/el2_mem.sv:131:+  assign mem_
end
Expand Down
10 changes: 0 additions & 10 deletions design/lib/el2_mem_if.sv
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,4 @@ interface el2_mem_if #(
input ic_tag_data_raw_packed_pre,ic_tag_data_raw_pre
);

modport veer_icache(
input clk,
// data
input ic_b_sb_wren, ic_b_sb_bit_en_vec, ic_sb_wr_data, ic_rw_addr_bank_q, ic_bank_way_clken_final, ic_bank_way_clken_final_up,
output wb_packeddout_pre, wb_dout_pre_up,
// tag
input ic_tag_clken_final, ic_tag_wren_q, ic_tag_wren_biten_vec, ic_tag_wr_data, ic_rw_addr_q,
output ic_tag_data_raw_packed_pre,ic_tag_data_raw_pre
);

endinterface
2 changes: 1 addition & 1 deletion testbench/veer_wrapper.sv
View file
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ module veer_wrapper

el2_veer_wrapper rvtop (
.el2_mem_export(mem_export.veer_sram_src),
.el2_icache_export(mem_export.veer_icache),
.el2_icache_export(mem_export.veer_icache_src),
.dmi_core_enable(dmi_core_enable),
.dmi_active(dmi_active),
.*
Expand Down

0 comments on commit edfbff6

Please sign in to comment.