feat(slurm_ops): loosen environment variable rules and configure openfile limits #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Changes: - Refactor `_AptManager` install mechanism to better encapsulate operations such as configuring apt to use Ubuntu HPC PPA, install packages based on the mapped service, and apply necessary overrides to systemd and ulimit. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Python 3.8 is no longer supported, and we don't target any bases that ship a Python version older than 3.10. Signed-off-by: Jason C. Nucciarone <[email protected]>
|
Yep, needs a rebase |
|
@jedel1043 R4R now that we're not getting ganked by Python |
jedel1043
approved these changes
Oct 11, 2024
…ons in log messages Co-authored-by: José Julián Espina <[email protected]>
|
Oops - latest commit message got messed up. I'll fix in a vbump PR tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting the
MYSQL_UNIX_PORTenvironment variable needed by slurmdbd to connect to MySQL via a unix socket, and it adds configs for expanding the allowed amount open files at once.This PR also improves the testing coverage of
_AptManagerby mocking several of the installation steps such as configuring apt to use the Ubuntu HPC PPA, writing security configurations, overriding service files, etc. It refactors the install function to (a) lower the cyclomatic complexity ofinstall- less if/else in a single function - and (b) very easy to unit test.Misc.
TestCaseclass.pyfakefs's version ofTestCaseinherits fromunittest.TestCase, so just don't callself.setupPyfakeFS()and it's pretty much the same 😓Related issues
_EnvManagerenvironment variable rules #43