Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix CI pipeline and add TiCS analysis action #45

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

jedel1043
Copy link
Contributor

  • Fixes the CI pipeline, since the recent upgrade to 24.04 broke it.
  • Adds a TiCS action that runs once every day.

Pins action image to Ubuntu 24.04, to avoid future breakages.
@NucciTheBoss NucciTheBoss self-requested a review October 11, 2024 01:16
@NucciTheBoss NucciTheBoss added the enhancement New feature or request label Oct 11, 2024
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pipx works for now as it's maintained by pypa. One thing we'll want to possibly look at is using the tox package from the Ubuntu Archive. We're currently not pinning the version, so if there's ever a tox 5 (or something gets deprecated), we'll need to keep an eye out for that.

Either way, this is part of a larger discussion about GitHub (like issue labels + repo access rules), so maybe we'll create a template repo where we can pull files from.

@NucciTheBoss NucciTheBoss merged commit a7b2633 into charmed-hpc:main Oct 11, 2024
4 checks passed
@NucciTheBoss
Copy link
Member

Unblocks #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants