Get the 'tests' task working again #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zack Cerza <[email protected]>
zmc
force-pushed
the
test-debug
branch
2 times, most recently
from
b38bb95
to
f6db3b7
Compare
This task has been broken for a very long time. It hasn't passed in years, and has additionally been masking test failures including some regressions. This commit: * Fixes masking of failures in setup/teardown methods * Actually runs all of our tests * Excludes tests that need remote nodes when they are not available * Improves logging and reporting * Adds support for running in CLI mode Signed-off-by: Zack Cerza <[email protected]>
Scheduled jobs are failing because they try to write to /home/ansible.log. Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Partially enabled by not passing MappingProxyType to it any longer. Signed-off-by: Zack Cerza <[email protected]>
This reflects reality and also fixes some linter errors. Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
|
@VallariAg ping |
VallariAg
approved these changes
Jul 23, 2024
| def __init__(self, ctx=None, config=None): | ||
| def __init__(self, ctx, config=None): |
There was a problem hiding this comment.
Just curious - why did we remove the default param value of "None" here?
There was a problem hiding this comment.
Good question! This was to fix the pyright error reportOptionalMemberAccess resulting from things like references to self.ctx.archive in teuthology.task.Ansible. The Task class was never really intended to be used without the ctx.
There was a problem hiding this comment.
Error messages like 'foo' is not a known member of 'None'
There was a problem hiding this comment.
Ohh I see, thank you for the explanation! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'tests' task had been broken for a very long time. It hasn't passed in years, and
had additionally been masking test failures including some regressions.
This PR:
Signed-off-by: Zack Cerza [email protected]