find_git_parents: Refresh mirror when required #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to do the refresh every time, which wasn't good. Then we didn't do it at all, which was fine until someone tried to schedule against a commit in the few minutes before the mirror picked it up. Let's try doing it when necessary :) Fixes: #66893 Signed-off-by: Zack Cerza <[email protected]>
dmick
approved these changes
Jul 17, 2024
kamoltat
approved these changes
Jul 17, 2024
Thanks - this run scheduled as I expected, and this codepath is only hit during scheduling. |
|
Failures in the linked test run are fixed by #1975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to do the refresh every time, which wasn't good. Then we didn't do it at all, which was fine until someone tried to schedule against a commit in the few minutes before the mirror picked it up. Let's try doing it when necessary :)
Fixes: #66893