Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring collections service #345

Open
wants to merge 37 commits into
base: project-orion
Choose a base branch
from

linter done

d90d733
Select commit
Loading
Failed to load commit list.
Open

Refactoring collections service #345

linter done
d90d733
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Feb 20, 2024 in 1s

52.70% of diff hit (target 67.68%)

View this Pull Request on Codecov

52.70% of diff hit (target 67.68%)

Annotations

Check warning on line 26 in app/controllers/collections-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/collections-controller.js#L24-L26

Added lines #L24 - L26 were not covered by tests

Check warning on line 53 in app/controllers/collections-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/collections-controller.js#L47-L53

Added lines #L47 - L53 were not covered by tests

Check warning on line 59 in app/controllers/collections-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/collections-controller.js#L55-L59

Added lines #L55 - L59 were not covered by tests

Check warning on line 70 in app/controllers/collections-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/collections-controller.js#L69-L70

Added lines #L69 - L70 were not covered by tests

Check warning on line 79 in app/controllers/collections-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/collections-controller.js#L76-L79

Added lines #L76 - L79 were not covered by tests

Check warning on line 82 in app/controllers/collections-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/collections-controller.js#L81-L82

Added lines #L81 - L82 were not covered by tests

Check warning on line 144 in app/controllers/collections-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/collections-controller.js#L143-L144

Added lines #L143 - L144 were not covered by tests

Check warning on line 46 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L41-L46

Added lines #L41 - L46 were not covered by tests

Check warning on line 49 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L48-L49

Added lines #L48 - L49 were not covered by tests

Check warning on line 72 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L66-L72

Added lines #L66 - L72 were not covered by tests

Check warning on line 76 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L75-L76

Added lines #L75 - L76 were not covered by tests

Check warning on line 79 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L78-L79

Added lines #L78 - L79 were not covered by tests

Check warning on line 88 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L87-L88

Added lines #L87 - L88 were not covered by tests

Check warning on line 94 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L91-L94

Added lines #L91 - L94 were not covered by tests

Check warning on line 118 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L116-L118

Added lines #L116 - L118 were not covered by tests

Check warning on line 133 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L129-L133

Added lines #L129 - L133 were not covered by tests

Check warning on line 140 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L137-L140

Added lines #L137 - L140 were not covered by tests

Check warning on line 155 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L154-L155

Added lines #L154 - L155 were not covered by tests

Check warning on line 161 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L158-L161

Added lines #L158 - L161 were not covered by tests

Check warning on line 173 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L164-L173

Added lines #L164 - L173 were not covered by tests

Check warning on line 175 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L175

Added line #L175 was not covered by tests

Check warning on line 184 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L180-L184

Added lines #L180 - L184 were not covered by tests

Check warning on line 192 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L191-L192

Added lines #L191 - L192 were not covered by tests

Check warning on line 202 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L200-L202

Added lines #L200 - L202 were not covered by tests

Check warning on line 206 in app/services/collections-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/collections-service.js#L204-L206

Added lines #L204 - L206 were not covered by tests