Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring collections service #345

Open
wants to merge 37 commits into
base: project-orion
Choose a base branch
from
Open

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Feb 20, 2024

No description provided.

@vsun757 vsun757 requested a review from ElJocko February 20, 2024 18:41
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 201 lines in your changes are missing coverage. Please review.

Comparison is base (4ad23ee) 67.68% compared to head (d90d733) 70.03%.
Report is 222 commits behind head on project-orion.

Files Patch % Lines
app/services/collections-service.js 51.41% 172 Missing ⚠️
app/controllers/collections-controller.js 46.29% 29 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #345      +/-   ##
=================================================
+ Coverage          67.68%   70.03%   +2.34%     
=================================================
  Files                144      151       +7     
  Lines              16788    14350    -2438     
  Branches            2068     1660     -408     
=================================================
- Hits               11363    10050    -1313     
+ Misses              5417     4290    -1127     
- Partials               8       10       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vsun757 vsun757 requested a review from seansica February 21, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant