Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Software service #339

Merged
merged 29 commits into from
Jan 24, 2024

Minor cleanup and formatting.

d721767
Select commit
Loading
Failed to load commit list.
Merged

Refactored Software service #339

Minor cleanup and formatting.
d721767
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 24, 2024 in 1s

67.14% of diff hit (target 68.84%)

View this Pull Request on Codecov

67.14% of diff hit (target 68.84%)

Annotations

Check warning on line 34 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L30-L34

Added lines #L30 - L34 were not covered by tests

Check warning on line 58 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L52-L58

Added lines #L52 - L58 were not covered by tests

Check warning on line 66 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L61-L66

Added lines #L61 - L66 were not covered by tests

Check warning on line 76 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L75-L76

Added lines #L75 - L76 were not covered by tests

Check warning on line 93 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L82-L93

Added lines #L82 - L93 were not covered by tests

Check warning on line 122 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L121-L122

Added lines #L121 - L122 were not covered by tests

Check warning on line 138 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L138

Added line #L138 was not covered by tests

Check warning on line 148 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L144-L148

Added lines #L144 - L148 were not covered by tests

Check warning on line 156 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L156

Added line #L156 was not covered by tests

Check warning on line 167 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L163-L167

Added lines #L163 - L167 were not covered by tests

Check warning on line 187 in app/controllers/software-controller.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/controllers/software-controller.js#L183-L187

Added lines #L183 - L187 were not covered by tests

Check warning on line 181 in app/services/attack-objects-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/attack-objects-service.js#L180-L181

Added lines #L180 - L181 were not covered by tests

Check warning on line 24 in app/services/software-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/software-service.js#L24

Added line #L24 was not covered by tests

Check warning on line 76 in app/services/software-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/software-service.js#L76

Added line #L76 was not covered by tests