Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Software service #339

Merged
merged 29 commits into from
Jan 24, 2024
Merged

Refactored Software service #339

merged 29 commits into from
Jan 24, 2024

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Jan 17, 2024

No description provided.

@vsun757 vsun757 requested review from ElJocko and seansica January 17, 2024 15:20
# Conflicts:
#	app/exceptions/index.js
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

13.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ElJocko ElJocko linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (6dd836e) 68.84% compared to head (d721767) 69.09%.
Report is 2 commits behind head on project-orion.

Files Patch % Lines
app/controllers/software-controller.js 52.00% 60 Missing ⚠️
app/services/software-service.js 90.16% 4 Missing and 2 partials ⚠️
app/services/attack-objects-service.js 62.50% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #339      +/-   ##
=================================================
+ Coverage          68.84%   69.09%   +0.25%     
=================================================
  Files                148      149       +1     
  Lines              15058    14777     -281     
  Branches            1767     1713      -54     
=================================================
- Hits               10366    10210     -156     
+ Misses              4683     4556     -127     
- Partials               9       11       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElJocko ElJocko merged commit ebd471c into project-orion Jan 24, 2024
2 of 4 checks passed
@ElJocko ElJocko deleted the software-test-293 branch January 24, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Software Service for Improved Structure and Asynchronicity
2 participants