Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rephrase MinSignedPerWindow description #2470

Closed
wants to merge 5 commits into from
Closed

docs: rephrase MinSignedPerWindow description #2470

wants to merge 5 commits into from

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 11, 2023

Closes #2469

The description is partially inspired by these docs. The default value is defined here.

@rootulp rootulp added documentation Improvements or additions to documentation specs directly relevant to the specs backport:v1.x PR will be backported automatically to the v1.x branch upon merging labels Sep 11, 2023
@rootulp rootulp added this to the Mainnet milestone Sep 11, 2023
@rootulp rootulp self-assigned this Sep 11, 2023
@celestia-bot celestia-bot requested a review from a team September 11, 2023 18:41
liamsi
liamsi previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is much better!

@rootulp rootulp enabled auto-merge (squash) September 12, 2023 14:11
liamsi
liamsi reviewed Sep 12, 2023
View reviewed changes
specs/src/specs/params.md Outdated Show resolved Hide resolved
specs/src/specs/params.md Show resolved Hide resolved
@rootulp rootulp requested a review from liamsi September 12, 2023 18:35
@celestiaorg celestiaorg deleted a comment from codecov-commenter Sep 12, 2023
cmwaters
cmwaters reviewed Sep 13, 2023
View reviewed changes
specs/src/specs/params.md Outdated Show resolved Hide resolved
rootulp
rootulp commented Sep 13, 2023
View reviewed changes
specs/src/specs/params.md Outdated Show resolved Hide resolved
@celestia-bot celestia-bot requested a review from a team September 13, 2023 14:09
@rootulp rootulp mentioned this pull request Sep 13, 2023
Closed
@celestiaorg celestiaorg deleted a comment from codecov-commenter Sep 13, 2023
@celestiaorg celestiaorg deleted a comment from codecov-commenter Sep 13, 2023
evan-forbes
evan-forbes approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, sorry for the conflicts I also noticed and changed some of the values in the other params PR

@rootulp
Copy link
Collaborator Author

rootulp commented Sep 14, 2023

Closing b/c no longer needed.

@rootulp rootulp closed this Sep 14, 2023
auto-merge was automatically disabled September 14, 2023 14:42

Pull request was closed

@rootulp rootulp deleted the rp/slashing-min-signed-description branch September 14, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@rootulp rootulp

Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging documentation Improvements or additions to documentation specs directly relevant to the specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minumum signatures in the block.
4 participants
@rootulp @liamsi @cmwaters @evan-forbes