Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent format for percentages in params.md #2479

Closed
rootulp opened this issue Sep 13, 2023 · 1 comment · Fixed by #2492
Closed

Consistent format for percentages in params.md #2479

rootulp opened this issue Sep 13, 2023 · 1 comment · Fixed by #2492
Assignees
@rootulp
Labels
documentation Improvements or additions to documentation specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 13, 2023

Could we keep the format for percentages constant i.e. if we're using decimal with parentheses for MinSignedPerWindow can we do the same for SlashFractionDoubleSign

Originally posted by @cmwaters in #2470 (comment)
@rootulp rootulp added documentation Improvements or additions to documentation specs directly relevant to the specs and removed needs:triage labels Sep 13, 2023
@rootulp rootulp added this to the Mainnet milestone Sep 13, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Sep 13, 2023 •
edited
Loading

IMO the first value should be the absolute value of the param (e.g. 0.05 or 1814400) and then in parenthesis we can include a human friendly format (e.g. (5%) or (21 days)).
.

@rootulp rootulp mentioned this issue Sep 13, 2023
Closed
@rootulp rootulp self-assigned this Sep 13, 2023
@rootulp rootulp mentioned this issue Sep 13, 2023
Merged
rootulp added a commit that referenced this issue Sep 18, 2023
@rootulp
docs: consistent format for percentages in params.md (#2492)
87f158c 
Closes #2479
mergify bot pushed a commit that referenced this issue Sep 18, 2023
@rootulp @mergify
docs: consistent format for percentages in params.md (#2492)
051b3e7 
Closes #2479

(cherry picked from commit 87f158c)
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
docs: consistent format for percentages in params.md (#2492)
cb300d8 
Closes celestiaorg/celestia-app#2479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation specs directly relevant to the specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: consistent format for percentages in params.md rootulp/celestia-app
1 participant
@rootulp