fix: remove direct projen dependency, only upgrade deps weekly
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The direct `projen` dependency leads to class conflicts in downstream TypeScript repositories, if downstream packages have their own dependency on `projen`. There will be multiple copies of `projen` in the dependency tree, and every class inside those copies will count as a different, incompatible class. Remove the direct dependency, we only need a `peerDependency`+`devDependency`.
kaizencc
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direct
projendependency leads to class conflicts in downstream TypeScript repositories, if downstream packages have their own dependency onprojen.There will be multiple copies of
projenin the dependency tree, and every class inside those copies will count as a different, incompatible class.Remove the direct dependency, we only need a
peerDependency+devDependency.