-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: remove direct
projen
dependency, only upgrade deps weekly (#320)
The direct `projen` dependency leads to class conflicts in downstream TypeScript repositories, if downstream packages have their own dependency on `projen`. There will be multiple copies of `projen` in the dependency tree, and every class inside those copies will count as a different, incompatible class. Remove the direct dependency, we only need a `peerDependency`+`devDependency`.
- Loading branch information
Showing
4 changed files
with
9 additions
and
9 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import { UpgradeDependenciesSchedule } from 'projen/lib/javascript'; | ||
import { generateYarnMonorepoOptions } from './projenrc/yarn-monorepo-options'; | ||
import { CdklabsJsiiProject } from './src'; | ||
|
||
|
@@ -9,14 +10,18 @@ const project = new CdklabsJsiiProject({ | |
defaultReleaseBranch: 'main', | ||
name: 'cdklabs-projen-project-types', | ||
repositoryUrl: 'https://github.com/cdklabs/cdklabs-projen-project-types.git', | ||
devDeps: ['@jsii/spec', 'jsii-reflect'], | ||
deps: ['projen'], | ||
devDeps: ['@jsii/spec', 'jsii-reflect', '[email protected]'], | ||
bundledDeps: ['yaml'], | ||
peerDeps: ['projen'], | ||
enablePRAutoMerge: true, | ||
cdklabsPublishingDefaults: false, | ||
upgradeCdklabsProjenProjectTypes: false, // that is this project! | ||
setNodeEngineVersion: false, | ||
depsUpgradeOptions: { | ||
workflowOptions: { | ||
schedule: UpgradeDependenciesSchedule.WEEKLY, | ||
}, | ||
}, | ||
peerDependencyOptions: { | ||
pinnedDevDependency: false, | ||
}, | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.