Skip to content

Commit

Permalink
fix: remove direct projen dependency, only upgrade deps weekly (#320)
Browse files Browse the repository at this point in the history
The direct `projen` dependency leads to class conflicts in downstream
TypeScript repositories, if downstream packages have their own
dependency on `projen`.

There will be multiple copies of `projen` in the dependency tree,
and every class inside those copies will count as a different,
incompatible class.

Remove the direct dependency, we only need a
`peerDependency`+`devDependency`.
  • Loading branch information
rix0rrr authored Nov 20, 2023
1 parent ae4782e commit 33536db
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 0 additions & 4 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions .projenrc.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { UpgradeDependenciesSchedule } from 'projen/lib/javascript';
import { generateYarnMonorepoOptions } from './projenrc/yarn-monorepo-options';
import { CdklabsJsiiProject } from './src';

Expand All @@ -9,14 +10,18 @@ const project = new CdklabsJsiiProject({
defaultReleaseBranch: 'main',
name: 'cdklabs-projen-project-types',
repositoryUrl: 'https://github.com/cdklabs/cdklabs-projen-project-types.git',
devDeps: ['@jsii/spec', 'jsii-reflect'],
deps: ['projen'],
devDeps: ['@jsii/spec', 'jsii-reflect', '[email protected]'],
bundledDeps: ['yaml'],
peerDeps: ['projen'],
enablePRAutoMerge: true,
cdklabsPublishingDefaults: false,
upgradeCdklabsProjenProjectTypes: false, // that is this project!
setNodeEngineVersion: false,
depsUpgradeOptions: {
workflowOptions: {
schedule: UpgradeDependenciesSchedule.WEEKLY,
},
},
peerDependencyOptions: {
pinnedDevDependency: false,
},
Expand Down
1 change: 0 additions & 1 deletion package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 33536db

Please sign in to comment.