Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/16 using definition #21

Merged
merged 5 commits into from
Dec 24, 2017
Merged

Conversation

emmanuel099
Copy link
Member

@emmanuel099 emmanuel099 commented Dec 23, 2017

Multiple test cases for using definitions.

Refs sealangdotorg/sea#16

Positive test cases:
* Alias of different types (basic, fixed size, relation)
* Alias of another using defition
* Alias of an enumeration

Negative test cases:
* Alias of unknown type
* Alias of an enumerator
* Redefinition
Copy link
Member

@ppaulweber ppaulweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks really good, but there is still a loose end regarding the error codes

Blue
}

using MyType = Color::Red //@ ERROR( ? )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no error code given, did you just forget it or does it even not exist in the FE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't exist in FE (master) when the test case was written.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

@emmanuel099
Copy link
Member Author

@ppaulweber please review it again

@ppaulweber ppaulweber merged commit 17dfd46 into master Dec 24, 2017
@ppaulweber ppaulweber deleted the feature/16_using_definition branch December 24, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants