-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/16 using definition #21
Conversation
Positive test cases: * Alias of different types (basic, fixed size, relation) * Alias of another using defition * Alias of an enumeration Negative test cases: * Alias of unknown type * Alias of an enumerator * Redefinition
E.g. forall t in TypeAlias do ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks really good, but there is still a loose end regarding the error codes
Blue | ||
} | ||
|
||
using MyType = Color::Red //@ ERROR( ? ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no error code given, did you just forget it or does it even not exist in the FE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't exist in FE (master) when the test case was written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done 👍
@ppaulweber please review it again |
Multiple test cases for using definitions.
Refs sealangdotorg/sea#16