Feature/16 using definition #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grammar rule is: USING Identifier = Type Refs sealangdotorg/sea#16
… to LHS Using cycles and not top-down ordered definitions are not handled at the moment. E.g. the following will fail because T1 depends on T2: ~~~ using T1 = T2; using T2 = ...; ~~~ This will be fixed by performing a top-sort of all "using definitions".
ppaulweber
requested changes
Dec 23, 2017
There was a problem hiding this comment.
overall nice PR and I'll approve it ASAP when the requested changes from casm-lang/libcasm-tc#21 are done!
Furthermore, in your PR description you are referencing a Refs #16. Does this reference an issue from this libcasm-fe repo or do you mean the feature issue sealangdotorg/sea#16 ?
| @@ -502,6 +507,14 @@ Enumerators | |||
| ; | |||
|
|
|||
|
|
|||
| UsingDefinition | |||
| : USING Identifier EQUAL Type | |||
|
Yes you are right, fixed! |
ppaulweber
approved these changes
Dec 24, 2017
| @@ -173,7 +182,8 @@ void TypeCheckVisitor::visit( BasicType& node ) | |||
| { | |||
| m_log.error( | |||
| { node.sourceLocation() }, | |||
| "cannot use " + symbol->description() + " '" + name + "' as type" ); | |||
| "cannot use " + symbol->description() + " '" + name + "' as type", | |||
| Code::TypeAnnotationInvalidBasicTypeName ); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace aliasing doesn't work atm, e.g.:
This requires some changes in the namespace resolving procedure and will be fixed in another PR (next release) to avoid breakages.
Using cycles and not top-down ordered definitions are not handled at the moment.
E.g. the following will fail because T1 depends on T2:
This will be fixed by performing a top-sort of all "using definitions" in another PR (next release).
Refs sealangdotorg/sea#16
See casm-lang/libcasm-tc#21 for tests