Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to canonicalize enum constants #70

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Attempt to canonicalize enum constants #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd22a52
Attempt to canonicalize enum constants
squarejesse Nov 20, 2024
54d258c
Just use the owner name
squarejesse Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions burst-kotlin-plugin/src/main/kotlin/app/cash/burst/kotlin/Argument.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ private fun enumValueArguments(
): List<Argument> {
val enumEntries = referenceClass.declarations.filterIsInstance<IrEnumEntry>()
val hasDefaultValue = parameter.defaultValue != null
val defaultEnumSymbol = parameter.defaultValue?.let { defaultValue ->
val defaultEnumSymbolName = parameter.defaultValue?.let { defaultValue ->
val expression = defaultValue.expression
when {
expression is IrGetEnumValue -> expression.symbol
expression is IrGetEnumValue -> expression.symbol.owner.name
expression is IrConst<*> && expression.value == null -> null
else -> unexpectedDefaultValue(parameter)
}
Expand All @@ -225,7 +225,7 @@ private fun enumValueArguments(
EnumValueArgument(
original = parameter,
type = parameter.type,
isDefault = hasDefaultValue && enumEntry.symbol == defaultEnumSymbol,
isDefault = hasDefaultValue && enumEntry.symbol.owner.name == defaultEnumSymbolName,
value = enumEntry,
),
)
Expand All @@ -235,7 +235,7 @@ private fun enumValueArguments(
NullArgument(
original = parameter,
type = parameter.type,
isDefault = hasDefaultValue && defaultEnumSymbol == null,
isDefault = hasDefaultValue && defaultEnumSymbolName == null,
),
)
}
Expand Down