Attempt to canonicalize enum constants #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Nov 20, 2024
| * It's possible we'll see two different [IrEnumEntrySymbol] instances for the same enum constant. | ||
| * This returns a canonical instance by looking up the enum by its name in this [IrPluginContext]. | ||
| * | ||
| * https://kotlinlang.slack.com/archives/C7L3JB43G/p1732121246270569 |
There was a problem hiding this comment.
You seem to not be following their advice, though. Seems like we could actually just be using the name to track the default (rather than fully-qualified name) since we know the type will always match.
There was a problem hiding this comment.
Lemme switch to just the name!
|
I couldn’t reproduce the problem in a test. When I attached the debugger to the compiler plug-in, it showed this problem for only 1 of 3 symbols, and I didn’t dig into why they were different. That seemed . . . difficult? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.