feat: add SendCmioResponse #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenctw
requested changes
Oct 24, 2024
mpernambuco
force-pushed
the
feature/send-cmio-response
branch
from
2fa30c6 to
274aba0
Compare
stephenctw
reviewed
Oct 25, 2024
stephenctw
reviewed
Oct 28, 2024
mpernambuco
force-pushed
the
feature/send-cmio-response
branch
from
274aba0 to
c76e239
Compare
stephenctw
approved these changes
Oct 30, 2024
stephenctw
requested changes
Nov 4, 2024
GCdePaula
reviewed
Nov 6, 2024
GCdePaula
reviewed
Dec 6, 2024
|
|
||
| function uint32Log2(uint32 value) internal pure returns (uint32) { | ||
| require(value > 0, "EmulatorCompat: log2(0) is undefined"); | ||
| return 31 - clz(value); |
There was a problem hiding this comment.
I think we want this to be:
32 - clz(value - 1)
Which yields ceil(log2(x)). With this change, the implementation of sendCmioResponse can be simplified by removing the branch that increments writeLengthLog2Size += 1;.
There was a problem hiding this comment.
clz(0) is undefined behavior (__builtin_clz).
The current implementation of uint32Log2 is correct for all valid inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendCmioResponseUarxh*toEmulator*Companion emulator PR: cartesi/machine-emulator#287