Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollups meta step #82

Merged
merged 23 commits into from
Dec 12, 2024
Merged

Rollups meta step #82

merged 23 commits into from
Dec 12, 2024

Conversation

stephenctw
Copy link
Contributor

@stephenctw stephenctw commented Oct 28, 2024

Depends on cartesi/machine-solidity-step#74 to pass the tests

@stephenctw stephenctw self-assigned this Oct 28, 2024
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch 4 times, most recently from 0fb3c08 to 17c170d Compare November 6, 2024 03:24
@stephenctw stephenctw linked an issue Nov 6, 2024 that may be closed by this pull request
3 tasks
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch from 17c170d to 2b92765 Compare November 10, 2024 14:03
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch 2 times, most recently from d72610f to 9a9b2bb Compare December 8, 2024 07:15
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch from 9a9b2bb to 0c46830 Compare December 8, 2024 07:32
@stephenctw
Copy link
Contributor Author

stephenctw commented Dec 8, 2024

An rollups integration test is added with a Lua orchestrator script which does the following:

  • spawn an Anvil blockchain
  • deploy necessary smart contracts
  • spawn an honest Rust Dave rollups node
  • send some inputs
  • spawn several Lua sybil nodes

Although the code may seem working fine, I still think we need to:

  • write a explorer tooling to monitor
    • what time does the tournament close
    • what's the current dangling commitment
    • list all dead commitments
    • and how many active matches, etc.
  • carefully review all the math/logic in the commitment calculation
  • test more sybil combinations/edge cases (uarch-reset, send-cmio) at meta-step call
  • polish the code with better engineering practice
  • more/better unit tests and coverage

To run the integration test with the following steps:

  • run make test-echo from the prt/tests/rollups directory, this will print all Lua logs, including the sybil players and the orchestrator
  • run docker exec rollups-echo-test tail -f dave.log on a separate terminal to see the logs produced by Rust Dave rollups node

@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch from 0c46830 to b5ae814 Compare December 8, 2024 08:08
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch from b5ae814 to 5820fd1 Compare December 9, 2024 00:53
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch from 96639e0 to 0efe627 Compare December 11, 2024 09:06
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch from 0efe627 to e64580b Compare December 11, 2024 09:11
@stephenctw stephenctw force-pushed the feature/rollups-meta-step branch from e64580b to ea06864 Compare December 11, 2024 15:23
GCdePaula
GCdePaula previously approved these changes Dec 12, 2024
Copy link
Collaborator

@GCdePaula GCdePaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Collaborator

@GCdePaula GCdePaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephenctw stephenctw merged commit dd918b6 into main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollups Metastep
3 participants