fix(windows-agent): Delegates agent.WaitReady to the daemon
#982
+71
−5
Commits on Nov 26, 2024
-
Revert "Temp workaround for flaky behaviour shown by TestLogs"
This reverts commit eb6c321. It's just one hunk, but I think reverting a commit is more meaningful.
-
Let the daemon advise when ready
The deamon knows best when is the most likely moment to be serving.
-
Agent defers to daemon to advise when ready
The a.ready channel is still useful to synchronize the access to a.daemon, preventing nil pointer access when the deamon is not yet initialized. Checking for nil is still needed, as the a.ready channel may be closed without ever serving.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.