fix(windows-agent): Delegates agent.WaitReady to the daemon
#982
+71
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eb6c321. It's just one hunk, but I think reverting a commit is more meaningful.
Till the latest moment possible.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 89.16% 89.18% +0.02%
==========================================
Files 110 110
Lines 7493 7498 +5
==========================================
+ Hits 6681 6687 +6
- Misses 633 634 +1
+ Partials 179 177 -2 ☔ View full report in Codecov by Sentry. |
The deamon knows best when is the most likely moment to be serving.
The a.ready channel is still useful to synchronize the access to a.daemon, preventing nil pointer access when the deamon is not yet initialized. Checking for nil is still needed, as the a.ready channel may be closed without ever serving.
CarlosNihelton
force-pushed
the
fix-agent-waitready
branch
from
0cc4ba9
to
8cb8854
Compare
didrocks
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #896 the agent might sometimes close the
a.readychannel too early, giving the possibility of a call toa.WaitReady()exiting before the daemon really starts serving, thus not really waiting.The deamon knows best when is the most likely moment to be serving, thus this PR slightly modifies
a.WaitReady()to check with the daemon, which had to implement its owndaemon.WaitReady().The
a.readychannel is still useful to synchronize the access toa.daemon, preventing nil pointer access when the deamon is not yet initialized. Checking fornilis still needed, as thea.readychannel may be closed without ever serving, such as on a failure case.This adds a test for
daemon.WaitReady(), but the agent tests don't need to change, as their "flakyness" reveal the problem.UDENG-4900