Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm64 support to smartctl-exporter workflow #97

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add arm64 support to smartctl-exporter workflow #97

merged 1 commit into from
Oct 1, 2024

Conversation

samuelallan72
Copy link
Contributor

No description provided.

@samuelallan72 samuelallan72 requested a review from a team as a code owner October 1, 2024 09:30
@samuelallan72 samuelallan72 mentioned this pull request Oct 1, 2024
Closed
gabrielcocenza
gabrielcocenza reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to change the snap_release.yaml.tfpl in order to fix what we saw in dcgm. Do you mind doing it in this PR? Otherwise it will overwrite with wrong template

@gabrielcocenza
Copy link
Member

I've created the #98 to fix it in a separate PR. Let's merge it before this one

@samuelallan72
Copy link
Contributor Author

The merge order shouldn't matter, because the auto PR will just get updated. :)

@samuelallan72 samuelallan72 merged commit f80ab70 into main Oct 1, 2024
46 checks passed
@samuelallan72 samuelallan72 deleted the smartctl-exporter-snap-arm64 branch October 1, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcocenza gabrielcocenza gabrielcocenza left review comments

@jneo8 jneo8 jneo8 approved these changes

@Pjack Pjack Pjack approved these changes

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray chanchiwai-ray is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelallan72 @gabrielcocenza @Pjack @jneo8