Update centrally managed files #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![soleng-terraform[bot]](https://avatars.githubusercontent.com/u/53057619?s=60&v=4){kind=small}
soleng-terraform
bot
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
rgildein and
Deezzir
Pjack
previously approved these changes
Sep 19, 2024
samuelallan72
requested changes
Sep 19, 2024
| python -m pip install 'tox<5' | ||
|
|
||
| - name: Run functional tests | ||
| run: tox -e func |
There was a problem hiding this comment.
this repo doesn't have a tox file, or any functional tests, so maybe we can't use this template :/
There was a problem hiding this comment.
We can add func test, and just do an endpoint testing because we don't necessarily have smart devices in the CI environment.
There was a problem hiding this comment.
It's a prefect case that using tox as an interface will encounter
It's ok to create an exception for this case right now from my point of view.
|
I'm aiming to add minimal tests in #7 |
|
Will be superceded by the automated PR created by canonical/solutions-engineering-automation#97 when it merges |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request from https://github.com/canonical/solutions-engineering-automation to update centrally managed files.