-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issues with rule 16 #52
Conversation
Fix rule16 to reduce processing time on MD code blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain what your trying to do in the regex? That would make it a lot easier to review and spot where it might go wrong.
Also, this rule won't catch code blocks that are created without explicit markup (through indentation).
I can confirm that this change solves an issue of Vale hanging when trying to process something in the https://github.com/canonical/kafka-operator docs. With the fix, vale produces the result quite fast. |
Fix additional processing issue with very long MD files by limiting rules to single code blocks.
Processing issue seems to have been resolved. Using
Rather than having to stop it after 20+ minutes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with the changes to fix/unblock the current processing, but the rules will need to be revisited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fix rule16 to reduce processing time on MD code blocks
Addresses #49