Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 16 breaks MD parsing #49

Closed
SecondSkoll opened this issue Jul 3, 2024 · 2 comments
Closed

Rule 16 breaks MD parsing #49

SecondSkoll opened this issue Jul 3, 2024 · 2 comments

Comments

@SecondSkoll
Copy link
Contributor

Not entirely sure why, need to have a better look into it, but rule 16 is currently causing Vale to hang when processing MD documents.

My Vale installation was hanging (on both Ubuntu 24.04 and Windows WSL running 20.04 in WSL2), so I started removing the most recently added rules to see which one might be causing the issue.

Targeting *.rst it was functioning fine, but * and *.md were both hanging. Removing rule 16 from the set fixed the issue.

Will do some investigation when I have time later this week.

@userMaximilian
Copy link

I encountered this problem (or at least a very similar problem) last week.

I think the regular expressions for ``` code blocks are being too 'greedy', resulting in Vale attempting to evaluate occurrences of // and # after the final code block - including within URLs. In addition, the overall time it takes to evaluate each of these occurrences appears to grow exponentially relative to the number of occurrences, leading to the appearance that Vale has frozen when provided with a complex enough Markdown file.

I tried tweaking the regular expressions in the rule file without success, although I didn't spend much time on it.

@SecondSkoll
Copy link
Contributor Author

Fixed with #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants