Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make CI compatible with juju controller 3.1.6 #72

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Oct 23, 2023

The juju.model.deploy(bundle) command somehow cause error if the controller version is 3.1.6


Replace line

# This line is not workable if controller version is 3.1.6
ops_test.model.deploy(bundle)

with

juju_cmd = ["deploy", "-m", ops_test.model_full_name, str(bundle)]
rc, stdout, stderr = await ops_test.juju(*juju_cmd)

Reference

The juju.model.deploy(bundle) command somehow cause error if the
controller version is 3.1.6
@jneo8 jneo8 requested review from a team, Pjack, aieri, agileshaw and rgildein October 23, 2023 08:13
Copy link
Contributor

@dashmage dashmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: name of function could be changed to script_dir.

tests/functional/test_charm.py Show resolved Hide resolved
Copy link

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, functional test pass in 2.9 & 3.1 good job.

Copy link
Contributor

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it's as a workaround. We should probably keep an eye on charmed-kubernetes/pytest-operator#116 since the root cause maybe fixed in a newer release.

@jneo8 jneo8 mentioned this pull request Oct 24, 2023
@jneo8 jneo8 merged commit 691b3db into canonical:master Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants