Feat/checksize #73
Merged
Feat/checksize #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jneo8
commented
Oct 24, 2023
•
jneo8
commented
- Only fetch tools which in required list
- Checking file size before running strategies
- Error handling for strategy install
Show missing resource block status if resource size is zero
dashmage
approved these changes
Oct 25, 2023
rgildein
reviewed
Nov 1, 2023
Comment on lines
+29
to
+31
| def __init__(self, tool: HWTool, path: Path): | ||
| """Init.""" | ||
| self.message = f"Tool: {tool} path: {path} size is zero" |
There was a problem hiding this comment.
This will not work properly.
example:
>>> class TestException(Exception):
... def __init__(self, arg1, arg2):
... self.message = f"test message with: {arg1}, {arg2}"
...
>>> raise TestException("a", "b")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TestException: ('a', 'b')We should use super().__init__(f"message").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.