-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testptp for TGPIO testing (Infra) #1249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is interesting, you initially vendorized the files from the intel project, but then you rolled back the commit and added the rule in the snapcraft.yaml. I've tested this, it snaps, it is fine but what about all the other platforms (we support source, debs and 4 other snaps beside 22)? Wi will never support tgpio on these platforms? Can you explain me why you decided to roll back the vendorization and add this as a part in the yaml instead?
You are right. My PR cannot fit other platforms. Do you have any idea how I could fix this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 45.87% 45.87%
=======================================
Files 367 367
Lines 39156 39156
Branches 6622 6622
=======================================
Hits 17961 17961
Misses 20504 20504
Partials 691 691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Add testptp for TGPIO testing #1239
Resolved issues
N/A
Documentation
N/A
Tests
N/A