Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testptp for TGPIO testing (Infra) #1249

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add testptp for TGPIO testing (Infra) #1249

merged 2 commits into from
Sep 27, 2024

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented May 16, 2024

Description

Add testptp for TGPIO testing #1239

Resolved issues

N/A

Documentation

N/A

Tests

N/A

@LiaoU3 LiaoU3 changed the title Add testptp for TGPIO testing Add testptp for TGPIO testing (New) May 16, 2024
@LiaoU3 LiaoU3 changed the title Add testptp for TGPIO testing (New) Add testptp for TGPIO testing (Infra) May 16, 2024
Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is interesting, you initially vendorized the files from the intel project, but then you rolled back the commit and added the rule in the snapcraft.yaml. I've tested this, it snaps, it is fine but what about all the other platforms (we support source, debs and 4 other snaps beside 22)? Wi will never support tgpio on these platforms? Can you explain me why you decided to roll back the vendorization and add this as a part in the yaml instead?

@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Jun 21, 2024

So this is interesting, you initially vendorized the files from the intel project, but then you rolled back the commit and added the rule in the snapcraft.yaml. I've tested this, it snaps, it is fine but what about all the other platforms (we support source, debs and 4 other snaps beside 22)? Wi will never support tgpio on these platforms? Can you explain me why you decided to roll back the vendorization and add this as a part in the yaml instead?

You are right. My PR cannot fit other platforms. Do you have any idea how I could fix this?
The reason why I rollback the commit is due to LP#2065260

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.87%. Comparing base (d3078dd) to head (c55e7d7).
Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   45.87%   45.87%           
=======================================
  Files         367      367           
  Lines       39156    39156           
  Branches     6622     6622           
=======================================
  Hits        17961    17961           
  Misses      20504    20504           
  Partials      691      691           
Flag Coverage Δ
provider-base 19.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hook25 Hook25 merged commit 2d42b1e into main Sep 27, 2024
41 checks passed
@Hook25 Hook25 deleted the add_testptp branch September 27, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants