Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tgpio test (New) #1239

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add tgpio test (New) #1239

wants to merge 10 commits into from

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented May 10, 2024

Description

Add TGPIO test from checkbox-provider-intliotg.

Resolved issues

N/A

Documentation

Please check README.md.

Tests

https://certification.canonical.com/hardware/202311-32338/submission/368615/

AI

I will add unittest once this is considered an approved PR.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to do in the pxus and a couple of minor changes in the python file (mostly style). I have also a few questions, see below

providers/base/units/tgpio/jobs.pxu Outdated Show resolved Hide resolved
providers/base/units/tgpio/jobs.pxu Show resolved Hide resolved
providers/base/units/tgpio/resource.pxu Outdated Show resolved Hide resolved
providers/base/units/tgpio/resource.pxu Show resolved Hide resolved
providers/base/units/tgpio/manifest.pxu Outdated Show resolved Hide resolved
providers/base/units/tgpio/resource.pxu Show resolved Hide resolved
providers/base/bin/tgpio.py Outdated Show resolved Hide resolved
providers/base/bin/tgpio.py Outdated Show resolved Hide resolved
@fernando79513 fernando79513 added the waiting-for-changes The review has been completed but the PR is waiting for changes from the author label Jul 16, 2024
@LiaoU3
Copy link
Contributor Author

LiaoU3 commented Aug 6, 2024

We are now waiting for #1249 to be merged and we are ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-changes The review has been completed but the PR is waiting for changes from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants