Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3900] Fix clearing banner bucket #714

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

em-may
Copy link
Contributor

@em-may em-may commented Nov 20, 2024

In #713 I missed an edge case, where trying to clear the banner bucket sets the db value to the empty string instead of null.

Testing

Tests added for this case and I verified with local Sherlock + Beehive.

@em-may em-may self-assigned this Nov 20, 2024
Copy link

No API changes detected

Copy link

github-actions bot commented Nov 20, 2024

Published image from 5705e88 (merge 8a1bfdf):

us-central1-docker.pkg.dev/dsp-artifact-registry/sherlock/sherlock:v1.6.15-8a1bfdf
us-central1-docker.pkg.dev/dsp-devops-super-prod/sherlock/sherlock:v1.6.15-8a1bfdf

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.76%. Comparing base (69e61d5) to head (5705e88).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lock/internal/api/sherlock/environments_v3_edit.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   66.78%   66.76%   -0.02%     
==========================================
  Files         292      292              
  Lines       16497    16503       +6     
==========================================
+ Hits        11017    11019       +2     
- Misses       4579     4582       +3     
- Partials      901      902       +1     
Files with missing lines Coverage Δ
...lock/internal/api/sherlock/environments_v3_edit.go 74.41% <33.33%> (-6.67%) ⬇️
---- 🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 20, 2024

@em-may em-may marked this pull request as ready for review November 20, 2024 19:38
@em-may em-may requested a review from a team as a code owner November 20, 2024 19:38
Copy link
Contributor

@choover-broad choover-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@em-may em-may merged commit b728e86 into main Nov 21, 2024
23 checks passed
@em-may em-may deleted the emay-DDO-3900-fix-clear-banner-bucket branch November 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants