-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDO-3900] Fix clearing banner bucket #714
Conversation
No API changes detected |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
==========================================
- Coverage 66.78% 66.76% -0.02%
==========================================
Files 292 292
Lines 16497 16503 +6
==========================================
+ Hits 11017 11019 +2
- Misses 4579 4582 +3
- Partials 901 902 +1
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find!
In #713 I missed an edge case, where trying to clear the banner bucket sets the db value to the empty string instead of null.
Testing
Tests added for this case and I verified with local Sherlock + Beehive.