Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-3900] Fix clearing banner bucket #714

Merged
merged 2 commits into from
Nov 21, 2024

tests

5705e88
Select commit
Loading
Failed to load commit list.
Merged

[DDO-3900] Fix clearing banner bucket #714

tests
5705e88
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 20, 2024 in 0s

66.76% (-0.02%) compared to 69e61d5

View this Pull Request on Codecov

66.76% (-0.02%) compared to 69e61d5

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.76%. Comparing base (69e61d5) to head (5705e88).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lock/internal/api/sherlock/environments_v3_edit.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   66.78%   66.76%   -0.02%     
==========================================
  Files         292      292              
  Lines       16497    16503       +6     
==========================================
+ Hits        11017    11019       +2     
- Misses       4579     4582       +3     
- Partials      901      902       +1     
Files with missing lines Coverage Δ
...lock/internal/api/sherlock/environments_v3_edit.go 74.41% <33.33%> (-6.67%) ⬇️
---- 🚨 Try these New Features: