-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API template #9
Open
banchan86
wants to merge
29
commits into
bonsai-rx:main
Choose a base branch
from
banchan86:api-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From open-ephys/bonsai-onix1-docs@c2e0bd4 Co-authored-by: Cris <[email protected]> Co-authored-by: Brandon Parks <[email protected]>
- The original template has code that enables display of enums values and description on some of the classes that use them - Some of it seems to be specific to OE nodes, but I have kept the one in the defineProperties function that applies generally
- Not sure what that section was doing but removing it didnt change anything, so it was probably OE specific
This reverts commit 428370d.
- Final version of OE template that retains all the features we want to port over - From here on out I am adding new features
- Adds namespace and definitions - Add inheritance, implements, and derived classes, but leaves out inherited members
Co-authored-by: Cris <[email protected]>
- replaceIObservableAndTSource edited to fit new refactored functions - sortProperties and defineEnumFields refactored Co-authored-by: Cris <[email protected]>
Co-authored-by: Cris <[email protected]> Co-authored-by: Brandon Parks <[email protected]>
This was referenced Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8.
Based off @cjsha and @bparks13 template for https://open-ephys.github.io/bonsai-onix1-docs/index.html
See Readme for usage instructions.
Might have a merge conflict with #7, because the way I started out with those 2 branches was by deleting files from each. But basically keep all the files that are present.
Original unmodified docs: https://bonsai-rx.org/pulsepal/api/Bonsai.PulsePal.ConfigureOutputChannel.html
Online preview of this PR: https://banchan86.github.io/pulsepal_docs_rev/api/Bonsai.PulsePal.ConfigureOutputChannel.html