Patch to support IncludeWorkflow operators #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From open-ephys/bonsai-onix1-docs@c2e0bd4 Co-authored-by: Cris <[email protected]> Co-authored-by: Brandon Parks <[email protected]>
- The original template has code that enables display of enums values and description on some of the classes that use them - Some of it seems to be specific to OE nodes, but I have kept the one in the defineProperties function that applies generally
- Not sure what that section was doing but removing it didnt change anything, so it was probably OE specific
This reverts commit 428370d.
- Final version of OE template that retains all the features we want to port over - From here on out I am adding new features
- Adds namespace and definitions - Add inheritance, implements, and derived classes, but leaves out inherited members
Co-authored-by: Cris <[email protected]>
- replaceIObservableAndTSource edited to fit new refactored functions - sortProperties and defineEnumFields refactored Co-authored-by: Cris <[email protected]>
Co-authored-by: Cris <[email protected]> Co-authored-by: Brandon Parks <[email protected]>
…chan86/docfx-tools_dev into api-template-includeworkflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of the proposed solution that resolves #16.
This is still in pretty rough shape, and so far only properties are present, but I wanted to get some feedback first to see if I am moving in the right direction before putting some more work into it. It might be hard (maybe even impossible?) to generate the property types and inputs/outputs in some scenarios.
See Readme for usage.
Online Preview at: https://banchan86.github.io/BonVision_env_dev/api/BonVision.Primitives.DrawGratings.html.
*Note - this also uses the API template in #9 because I was testing it with that final look in mind.